[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1572762 - /subversion/trunk/build/ac-macros/serf.m4

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 28 Feb 2014 12:42:15 -0500

On 02/28/2014 11:31 AM, Branko Čibej wrote:
> On 27.02.2014 23:26, breser_at_apache.org wrote:
>> Author: breser
>> Date: Thu Feb 27 22:26:46 2014
>> New Revision: 1572762
>> URL: http://svn.apache.org/r1572762
>> Log:
>> Fix a number of problems with our serf configure detection.
>> build/ac-macros/serf.m4
>> (): Update the description
> I've been trying to figure out where people found this format for
> top-level descriptions in log messages. I see them more and more
> often. Surely not from HACKING, which clearly says it should be:
> * build/ac-macros/serf.m4: Update the description.

I think this follows from the problem of making both symbol-specific and
top-level changes in a given file. Some folks do this:

* build/ac-macros/serf.m4:
  Update the description.
 (some_func): Twiddle the deeznits.

Others dislike the inconsistency, and prefer instead:

* build/ac-macros/serf.m4:
 (): Update the description.
 (some_func): Twiddle the deeznits.

Once you establish a habit of the latter, it sorta follows that when you
have only top-level changes, you stick with your established pattern.

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development
Received on 2014-02-28 18:42:53 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.