[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] pager support for command line client

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 04 Feb 2014 09:14:52 +0000

Ben Reser <ben_at_reser.org> writes:

> On 2/3/14, 4:31 PM, Daniel Shahaf wrote:
>> Do you need to call __close if there is an error after __start? i.e.,
>> is there a state in which stdout will be printed to in the error path?
> Yes you do. Just try running svn diff against a non-working copy. You'll end
> up with a broken terminal that you have to reset to see what you're doing.

We want some pattern that ensures __close is always called even when an
error is returned part way through. Either a pool cleanup or some sort
of __with_pager(). Otherwise we have to ensure that none of the error
pass bypass __close, e.g.

  PAGER=less svn diff wc file:///

leaves me needing to reset my terminal.

Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2014-02-04 10:15:37 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.