Re: [PATCH] pager support for command line client

On 2/3/14, 4:31 PM, Daniel Shahaf wrote:
> Do you need to call __close if there is an error after __start? i.e.,
> is there a state in which stdout will be printed to in the error path?

Yes you do. Just try running svn diff against a non-working copy. You'll end
up with a broken terminal that you have to reset to see what you're doing.

> What about the case SVN_PAGER="/nonexistent"? Should it fall back to
> just printing to stdout, or bail out on account of failing to execute
> "/nonexistent"?

Print to stdout with a warning why the pager isn't working.
Received on 2014-02-04 07:13:25 CET