Re: svn commit: r1552324 - Introduce svn_ra_session_dup()
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Fri, 20 Dec 2013 14:58:45 +0000 (GMT)
Bert Huijben wrote:
> svn_ra_session_open4 already uses some variables from the config without
(It's svn_ra_open4.) That's undocumented. That sounds like a bug. Since it's already released, we should update the doc string to say so, but going forward do we want to continue that practice? I would have thought it better (less surprising) not to do so.
> svn_ra_dup_session() documents that it will re-use the original arguments
That's not how I interpret what it currently says:
Please make that doc string more explicit if the intent is that the original 'config' and other pointers must still be valid.
Also svn_ra_open4() should document the lifetime requirements of each of its arguments, and for the compound arguments ('callbacks', 'callback_baton', 'config') whether the structures themselves or only (specified) items within them need to live for the duration of the session.
> (And Ra serf already did some internal session duplication before this
p.s. Please avoid top-posting and HTML on this list.
>From: Julian Foad
This is an archived mail posted to the Subversion Dev mailing list.