[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1552324 - in /subversion/trunk/subversion: include/ libsvn_client/ libsvn_ra/ libsvn_ra_local/ libsvn_ra_serf/ libsvn_ra_svn/

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Thu, 19 Dec 2013 23:28:35 +0400

On 19 December 2013 20:09, <rhuijben_at_apache.org> wrote:
> Author: rhuijben
> Date: Thu Dec 19 16:09:26 2013
> New Revision: 1552324
>
> URL: http://svn.apache.org/r1552324
> Log:
> Introduce a new ra api: svn_ra_session_dup() which allows opening a new ra
> session from an existing ra session. While this by itself might help
> performance in a few specific scenarios where opening a repository is
> expensive, it also allows moving certain kinds of ra backwards
> compatibility code into the ra layer itself, that are otherwise impossible.
>
> Update two usages to add some test coverage.
>
> * subversion/include/svn_ra.h
> (svn_ra_dup_session): New function.
>
> * subversion/libsvn_client/diff.c
> (diff_repos_repos,
> diff_summarize_repos_repos): Showcase for testing. Update caller.
>
> * subversion/libsvn_ra/ra_loader.c
> (svn_ra_dup_session): New function.
>
I considered this approach, but decided then it will be better to add
optional EXISTING_SESSION argument to svn_ra_open() function. Because
current svn_ra_dup_session() uses the same callbacks and parameters
for new session which could lead strange side effects.

-- 
Ivan Zhakov
Received on 2013-12-19 20:29:30 CET

This is an archived mail posted to the Subversion Dev mailing list.