[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Specifying commit timestamps over RA

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 02 Dec 2013 09:32:56 +0000

Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:

> Stefan Fuhrmann wrote on Thu, Nov 28, 2013 at 08:02:49 +0100:
>> On Wed, Nov 27, 2013 at 11:34 PM, Philip Martin
>> <philip.martin_at_wandisco.com>wrote:
>>
>> I'm a bit relucant to use them because I'm not altogether happy with the
>> > way they are removed from the transaction before we know whether the
>> > commit will succeed.
>> >
>>
>> Just an idea: Why not keep the ephemeral props
>> until the commit almost completed:

The current ephemeral properties implementation is in libsvn_repos. I
suppose we could move it into every FS implementation but I wasn't
planning that.

> How about just doing it *after* the commit completed? That is, inside
> commit_body() after 'current' has been incremented?
>
> There's a very small window where clients will see them, but all they'll
> see is an unrecognized property in the svn:* namespace, so they're
> supposed to ignore it. The overall effect won't be much different from
> that stray "is-fresh-txn-root: y" on committed noderevs.
>
> (I'm not sure it's a good idea, but it definitely is robust against
> power-downs, so I'm putting it on the table anyway.)

is-fresh-txn-root wasn't visible over RA and was mostly ignored by our
existing code. It's likely this property would be visbile over RA and
while new clients could ignored it existing clients would likely treat
it as any other revprop: display it, replicate it, etc.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2013-12-02 10:33:31 CET

This is an archived mail posted to the Subversion Dev mailing list.