[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Log-addressing branch ready for review

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Mon, 25 Nov 2013 14:44:56 +0100

On Mon, Nov 25, 2013 at 1:29 PM, Philip Martin <philip_at_codematters.co.uk>wrote:

> Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> writes:
>
> > On Tue, Sep 24, 2013 at 6:51 PM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
> >
> >> On 23 August 2013 03:21, Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
> >> wrote:
> >> > Hi all,
> >> >
> >> > As of r1516665, work on this branch has been completed.
> >> > Please review. See the BRANCH-README for the list of
> >> > major changes.
> >> >
> >> > If there are no objections, I will merge the code in the week
> >> > of Sep 23th.
> >> >
> >> Hi Stefan,
> >>
> >> I have looked through the code but I'm not ready to put my +1 on it. I
> >> think this branch is a good candidate for the "three +1" policy
> >> discused some time ago.
> >>
> >
> > Would you vote +1 under the 3-vote policy ("seems o.k. but more
> > independent review should take place")?
>
> I've been reviewing this branch and I am now happy for it to be merged
> to trunk.
>

Thanks a lot, Philip!
I plan on merging the branch later this week (Friday-ish).

-- Stefan^2.
Received on 2013-11-25 14:46:02 CET

This is an archived mail posted to the Subversion Dev mailing list.