Re: [PATCH] initialize some variables in test to prevent -Wmaybe-uninitialized
Julian Foad wrote:
> +1 to commit. That's me stating my approval. You're listed as a
> committer on the translations, so you can just add a line in the log message
> saying "Approved by: julianfoad" (or "Approved by: danielsh"
> since he said so in the previous email) and you should be able to commit it
> yourself . Let us know if you can't, for any reason.
I see you have committed this. I have edited the log message to add the "Approved by" line.
> Thanks for caring.
> - Julian
> Andreas Stieger wrote:
>> thanks for review. I get the comments about this being a rather
>> unimportant warning as it's all test code, but still less warnings are
>> better. Updated patch with TRUE/FALSE attached.
>> * subversion/tests/libsvn_fs/fs-test.c
>> (check_entry_present, check_entry_absent),
>> * subversion/tests/libsvn_fs_base/fs-base-test.c
>> (check_entry_present, check_entry_absent, check_id_present,
>> check_id_absent): initialize variable present to silence
>> warning -Wmaybe-uninitialized
Received on 2013-11-25 14:02:51 CET
This is an archived mail posted to the Subversion Dev