[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fwd: [PATCH] Fix for `svn patch` changing permissions of patched files

From: Branko Čibej <brane_at_wandisco.com>
Date: Fri, 22 Nov 2013 16:27:28 +0100

On 22.11.2013 15:23, Bert Huijben wrote:
>> Branko: On Windows we never alter permissions. We let the inherited folder
>> permission handle these things. A really nice case where the ACL's make our
>> code easier, by not letting user code worry about this.
>> (There is also a per user temporary directory instead of one for all users)

That's not quite the case. We often create temp files in the top-level
.svn/tmp directory; and the inherited permissions there can be
completely different than the ones on the target (likewise for the
user's temp dir). When we move these files into place, they may have
"wrong" permissions. We've had complaints on users@ about that.

(Not that I necessarily agree with the complaints, but they're there.)

> And even if we would try to do this, it is very likely to fail as
> managing permissions is commonly not something that the owner/creator
> of a file is even allowed to do.

Yup. That's why I said it's way too much "fun" on Windows.

-- Brane

Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane_at_wandisco.com
Received on 2013-11-22 16:28:07 CET

This is an archived mail posted to the Subversion Dev mailing list.