Re: Fwd: [PATCH] Fix for `svn patch` changing permissions of patched files

"Bert Huijben" <bert_at_qqmail.nl> writes:

>> - svn_subst_copy_and_translate4 uses the parent directory of a
>> temporary file as the temporary directory for a call to
>> svn_io_open_unique_file3. That causes svn_io_open_unique_file3 to
>> set the permissions on the file according to umask.
>
> This sounds like a left over of the .svn/tmp directories in the old
> per directory working copies.
>
> It should probably use either the right .svn/tmp directory below the
> working copy root or the system temporary folder. But as a subst
> function it can't get the working copy information.

We want to limit use of the system temp dir for various reasons:

  - the system dir may be a small filesystem with much less space than
    the working copy filesystem

  - if Subversion is interrupted files left in the system dir can't
    easily be removed later by Subversion

A write operation, such as update, can simply use .svn/tmp and avoid
these problems but we want read operations, such as diff and status, to
work on read-only working copies. Perhaps read operations should use
.svn/tmp if possible and fall back on the system dir if .svn/tmp is not
writeable.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*