[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1524145 - /subversion/trunk/subversion/svn/conflict-callbacks.c

From: Ben Reser <ben_at_reser.org>
Date: Wed, 13 Nov 2013 09:26:23 -0800

On 11/13/13 12:06 AM, Stefan Sperling wrote:
> Fair enough. Can you please add your rationale to the issue as well
> so the original reporter will see it?
> While at it, please reopen the issue and set the milestone to 1.9.x.
> I'll try to get it this done then and also address the issues you've
> raised. I agree the error handling seems flaky.
> I don't think the comment about exit codes you cited was added by me.
> I'll have to investigate what was intended there.

I was less than clear on where my veto applies. I'm -1 on the backport with
the specific issues I raised. I'm like -0 on the backport if those issues are
resolved. If other people think changing the behavior of those commands is ok
in 1.8.x I'm not going to stand in the way.

More than anything the error handling just doesn't make any sense to me.
Received on 2013-11-13 18:27:08 CET

This is an archived mail posted to the Subversion Dev mailing list.