[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1524145 - /subversion/trunk/subversion/svn/conflict-callbacks.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 13 Nov 2013 09:06:39 +0100

On Tue, Nov 12, 2013 at 08:20:37PM -0800, Ben Reser wrote:
> I'm not sure what we should be doing here but this much I can say this change
> shouldn't be backported. At least not yet. Though I'm really not sure how I
> feel about even backporting this to 1.8 since it pretty dramatically changes
> the interface's behavior in ways that may be surprising to users.
>
> As such I'm voting -1 on this backport on the 1.8.x change.

Fair enough. Can you please add your rationale to the issue as well
so the original reporter will see it?

While at it, please reopen the issue and set the milestone to 1.9.x.
I'll try to get it this done then and also address the issues you've
raised. I agree the error handling seems flaky.

I don't think the comment about exit codes you cited was added by me.
I'll have to investigate what was intended there.

Thanks!
Received on 2013-11-13 09:07:50 CET

This is an archived mail posted to the Subversion Dev mailing list.