[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1535399 - in /subversion/trunk/subversion: libsvn_fs_fs/ libsvn_fs_x/ libsvn_subr/ libsvn_wc/ mod_authz_svn/ tests/cmdline/ tests/libsvn_client/ tests/libsvn_fs_fs/ tests/libsvn_fs_x/ tests/libsvn_subr/ tests/libsvn_wc/

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 25 Oct 2013 10:40:37 +0100

Branko Čibej <brane_at_wandisco.com> writes:

> Sideline: *IF* we, as a community, agree to do this, then: (a) the rule
> should be documented in HACKING, and (b) there should be a '#define
> NULLPTR ((void*)0)' or reasonable facsimile in either svn_types.h or
> svn_private_config.h. I really do not want to see '(char*)NULL' all over
> the place. That's ... unsightly.

That would be incompatible with C++ since (void*) doesn't automatically
convert to (char*) by default. I'd like to avoid such incompatibilities
because I'd like to be able to use a C++ compiler at some point to catch
things like enum mismatches. I suppose we could have NULLCHARPTR for
variadic functions expecting (char*) which is the common case.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2013-10-25 11:41:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.