Re: svn commit: r1508170 - in /subversion/trunk:

Stefan Fuhrmann wrote on Thu, Aug 01, 2013 at 12:31:27 +0200:
> On Thu, Aug 1, 2013 at 6:36 AM, Daniel Shahaf <danielsh_at_elego.de> wrote:
> > #define svn_hash_sets(ht, key, val) \
> > apr_hash_set(ht, key, APR_HASH_KEY_STRING, val)
> >
>
> I would keep the current code for that. I allows for the
> compiler optimization and does not have the double
> parameter evaluation problem that the getter had.
>

<@danielsh> stefan2: oh, I missed your mail suggesting to keep _sets as is.
<@stefan2> danielsh: well, it's done now
<@stefan2> It's not super important

>
> > and strip all the dunder-builtins stuff.
> >
>
> BTW, could you educate me about the term "dunder"?
> It's certainly nothing to do with underwear.

"D[ouble] under[score]". I borrowed the term from Python.
Received on 2013-08-01 13:02:56 CEST