Re: svn commit: r1508170 - in /subversion/trunk:

On Thu, Aug 1, 2013 at 6:36 AM, Daniel Shahaf <danielsh_at_elego.de> wrote:

> Daniel Shahaf wrote on Thu, Aug 01, 2013 at 05:47:58 +0300:
> > Stefan Fuhrmann wrote on Wed, Jul 31, 2013 at 23:21:45 +0200:
> > > * revert svn_hash_gets to simply use APR_HASH_KEY_STRING
> >
> > ...
> >
> > > * where it is being used, make svn_private_config.h the first #include
> >
> > Why would the order of includes matter? Do you plan to still use
> > SVN_HAS_DUNDER_BUILTINS in svn_hash_sets()?
>
> Personally I'd simply revert back to the code right now on the 1.8
> branch:
>
> #define svn_hash_gets(ht, key) \
> apr_hash_get(ht, key, APR_HASH_KEY_STRING)
>

o.k.

> #define svn_hash_sets(ht, key, val) \
> apr_hash_set(ht, key, APR_HASH_KEY_STRING, val)
>

I would keep the current code for that. I allows for the
compiler optimization and does not have the double
parameter evaluation problem that the getter had.

> and strip all the dunder-builtins stuff.
>

BTW, could you educate me about the term "dunder"?
It's certainly nothing to do with underwear.

-- Stefan^2.
Received on 2013-08-01 12:31:59 CEST