Re: fsfs-improvements branch complete

On Mon, Jul 29, 2013 at 3:21 PM, Philip Martin
<philip.martin_at_wandisco.com>wrote:

> Philip Martin <philip.martin_at_wandisco.com> writes:
>
> > Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> writes:
> >
> >> Thanks for spotting & fixing this!
> >> The extra "_" was a recent addition to make output match /trunk.
> >
> > Another difference: db/txn-current produced by the branch does not have
> > a trailing \n. It works, but it might be better if it was the same as
> > trunk.
>

Fixed in r1508096.

> In r1506545 you changed transaction.c:get_and_increment_txn_key_body and
> removed the code that added the newline, but you left the comment saying
> that the newline was being added. What is the intention here?
>

This was a simple oversight. I tried to get the switch
to using svn_io_write_atomic carried over from /trunk
and missed the newline part.

-- Stefan^2.
Received on 2013-07-29 17:22:53 CEST