[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fsfs-improvements branch complete

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 29 Jul 2013 14:21:51 +0100

Philip Martin <philip.martin_at_wandisco.com> writes:

> Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> writes:
>
>> Thanks for spotting & fixing this!
>> The extra "_" was a recent addition to make output match /trunk.
>
> Another difference: db/txn-current produced by the branch does not have
> a trailing \n. It works, but it might be better if it was the same as
> trunk.

In r1506545 you changed transaction.c:get_and_increment_txn_key_body and
removed the code that added the newline, but you left the comment saying
that the newline was being added. What is the intention here?

-- 
Philip Martin | Subversion Committer
WANdisco | Non-Stop Data
Received on 2013-07-29 15:22:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.