[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Problem with Perl bindings?

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 25 Jul 2013 12:56:19 +0100

Roderich Schupp <roderich.schupp_at_gmail.com> writes:

> One small nit with the version for trunk, though: svn_hash_sets is actually
> apr_hash_set(hash, key, strlen(key), val), i.e. it assumes key is a
> NUL terminated string. Strings in Perl are usually specified as (pointer,
> len)
> pairs (because they may contain NUL bytes). But AFAIK Perl also
> guarantees that there is always a trailing NUL byte at pointer+len,
> so using strlen(key) should be safe here.

apr_pstrmemdup guarantees a null byte.

-- 
Philip Martin | Subversion Committer
WANdisco | Non-Stop Data
Received on 2013-07-25 13:57:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.