Re: Problem with Perl bindings?

On Thu, Jul 25, 2013 at 1:19 PM, Philip Martin
<philip.martin_at_wandisco.com>wrote:

> Fixes go on trunk first, and then get backported to 1.8 and 1.7. I can
> reproduce the bug on trunk, valgrind shows:
> ...
> and your patch, modified for trunk, fixes it:
>

Thanks for the speedy confirmation, Philip.
I'm going to commit this to trunk and nominate for backports to 1.7 and 1.8.

One small nit with the version for trunk, though: svn_hash_sets is actually
apr_hash_set(hash, key, strlen(key), val), i.e. it assumes key is a
NUL terminated string. Strings in Perl are usually specified as (pointer,
len)
pairs (because they may contain NUL bytes). But AFAIK Perl also
guarantees that there is always a trailing NUL byte at pointer+len,
so using strlen(key) should be safe here.

Cheers, Roderich
Received on 2013-07-25 13:49:16 CEST