[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1505006 - in /subversion/trunk: ./ subversion/include/svn_io.h subversion/libsvn_client/patch.c subversion/libsvn_fs_fs/fs_fs.c subversion/libsvn_subr/io.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Sat, 20 Jul 2013 02:23:24 +0400

On Sat, Jul 20, 2013 at 2:05 AM, Bert Huijben <bert_at_qqmail.nl> wrote:
>> -----Original Message-----
>> From: stefan2_at_apache.org [mailto:stefan2_at_apache.org]
>> Sent: vrijdag 19 juli 2013 22:46
>> To: commits_at_subversion.apache.org
>> Subject: svn commit: r1505006 - in /subversion/trunk: ./
>> subversion/include/svn_io.h subversion/libsvn_client/patch.c
>> subversion/libsvn_fs_fs/fs_fs.c subversion/libsvn_subr/io.c
>>
>> Author: stefan2
>> Date: Fri Jul 19 20:46:22 2013
>> New Revision: 1505006
>>
>> URL: http://svn.apache.org/r1505006
>> Log:
>> Merge revisions r1433848,1438408,1445080 from branches/fsfs-format7.
>> These introduce svn_io_file_create_empty and svn_io_file_create_binary
>> as alternatives to svn_io_file_create.
>>
>> A few conflicts had to be resolved.
>
> Can you combine the original log messages to get a proper description here with the function
> additions. This makes it much easier to see when code was introduced when looking
> through the file history.
I agree with Bert that including original log message would be really
nice to review such merges properly. Actually I prefer to have full
log messages for merges describing all changes like they did to trunk
without committing to branch. Because I don't follow feature branches,
but want to review trunk commits.

-- 
Ivan Zhakov
Received on 2013-07-20 00:24:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.