RE: svn commit: r1505006 - in /subversion/trunk: ./ subversion/include/svn_io.h subversion/libsvn_client/patch.c subversion/libsvn_fs_fs/fs_fs.c subversion/libsvn_subr/io.c

> -----Original Message-----
> From: stefan2_at_apache.org [mailto:stefan2_at_apache.org]
> Sent: vrijdag 19 juli 2013 22:46
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1505006 - in /subversion/trunk: ./
> subversion/include/svn_io.h subversion/libsvn_client/patch.c
> subversion/libsvn_fs_fs/fs_fs.c subversion/libsvn_subr/io.c
>
> Author: stefan2
> Date: Fri Jul 19 20:46:22 2013
> New Revision: 1505006
>
> URL: http://svn.apache.org/r1505006
> Log:
> Merge revisions r1433848,1438408,1445080 from branches/fsfs-format7.
> These introduce svn_io_file_create_empty and svn_io_file_create_binary
> as alternatives to svn_io_file_create.
>
> A few conflicts had to be resolved.

Can you combine the original log messages to get a proper description here with the function additions. This makes it much easier to see when code was introduced when looking through the file history.

Looking at just this merge it is not clear why svn_io_file_create_binary() needs to be added, and what additional features these functions have over svn_io_file_create(), which already creates a text file with binary encoding.

With the diff it is clear, but the reason why belongs in the log message.

Looking at the diff, I understand the value of svn_io_file_create_binary(), but svn_io_file_create_empty() still looks like a convenience function for creating empty files, while you could just pass "", 0 to svn_io_file_create_binary().

And looking at the performance of the old working copy format on Windows, I'm certainly not recommending new code to create many empty files at once.
(File creations have very bad performance characteristics on Windows and network shares)

        Bert
Received on 2013-07-20 00:06:03 CEST