[PATCH] Properly format the error message for the 'svn diff --old A --new B' commands

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Mon, 8 Jul 2013 15:57:16 +0400

Hi,

Currently it is possible to compare arbitrary versioned or unversioned files or
directories using the 'svn diff --old A --new B' command [1]. Running this
command may produce errors and on my Windows machine the
corresponding error messages contain paths with incorrect separators.

- For example, running 'svn diff --old doc --new win-tests.py' on a fresh
subversion/trunk checkout produces the following message:

[[[
svn: E145001: 'C:/Projects/Subversion/doc' is not the same node kind as
'C:/Projects/Subversion/win-tests.py'
]]]

- Running 'svn diff --old DOES-NOT-EXIST --new DOES-NOT-EXIST' in the same case
produces the following message:

[[[
svn: E145001: 'C:/Projects/Subversion/DOES-NOT-EXIST' is not a file or directory
]]]

I've attached a patch that fixes the described problems (we should use
'svn_dirent_local_style' for path formatting in the error messages produced by
the 'svn_client__arbitrary_nodes_diff' function).

[1] http://svn.apache.org/viewvc?view=revision&revision=1310291

Thanks and regards,
Evgeny Kotkov

text/plain attachment: improve-svn-diff-error-message.patch.txt

text/plain attachment: improve-svn-diff-error-message.log.txt

Received on 2013-07-08 13:58:18 CEST

This message: [ Message body ]
Next message: Stefan Sperling: "Re: [PATCH] Properly format the error message for the 'svn diff --old A --new B' commands"
Previous message: neels_at_apache.org: "[svnbench] Revision: 1500554 compiled Jul 8 2013, 00:22:05 on x86_64-unknown-linux-gnu"
Next in thread: Stefan Sperling: "Re: [PATCH] Properly format the error message for the 'svn diff --old A --new B' commands"
Reply: Stefan Sperling: "Re: [PATCH] Properly format the error message for the 'svn diff --old A --new B' commands"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]