[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.8.0 and mmap()

From: NormW <normw_at_gknw.net>
Date: Sun, 30 Jun 2013 08:16:12 +1000

On 29/06/2013 9:54 PM, NormW wrote:
> On 29/06/2013 8:38 PM, Branko ─îibej wrote:
>> On 29.06.2013 10:09, NormW wrote:
>>> Hi All,
>>> Pardon for the noise.
>>> I could build all .c executables in 1.7.x (<=.10) but find the 1.8.0
>>> series has mmap(), which my now 'dated' OS does not have. Two files
>>> have the function, namely:
>>
>> Let me guess ... Windows 95? (Or "98" or "Me" or whatever they wanted to
>> call it)
> No... A bit further upmarket, in the server category, NetWare, but I'm
> old enough to have used both. Presently "learning" with 1.7.10 on NW6.5.
>
>>> libsvn_diff\diff_file.c,
>>> libsvn_subr\named_atomic.c
>>>
>>> The former is guarded by an #if !APR_HAS_MMAP substitute, while the
>>> second file does not; the question then 'is there (likely to be) a
>>> suitable alternate to use of mmap in named_atomic.c in the foreseeable
>>> future?' or have I arrived at the end of the branch?
>>
>> Looks like it could be fixed, as the code does have an explicit check
>> for named atomic support; it just doesn't use the APR_HAS_MMAP flag as
>> well. Can you try the attached patch?
Works for me! All now builds.

The attached diff (DOS EOL) is the only other tweak needed:

> --- stream-test.c.orig 2013-01-10 06:24:52.000000000 +1100
> +++ stream-test.c 2013-06-19 08:36:45.109375000 +1000
> @@ -695,7 +695,7 @@
> },
> {
> NULL,
> - NULL,
> + NULL
> },
> };
> int i;

> Thanks for a _very_ quick reply and will certainly give it a go in the
> morning! (10pm and fuzzy vision are not conducive to useful computing.)
>
>> -- Brane
> Thx!
> Norm
Thanks again.
I also note the 'no 64 switch' patch for client.c made it into 1.8.0.
Regards,
Norm

Received on 2013-06-30 00:17:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.