[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1498000 - /subversion/trunk/subversion/libsvn_ra_serf/inherited_props.c

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 29 Jun 2013 17:01:13 -0400

Looks good. One small note:

On Sat, Jun 29, 2013 at 3:51 PM, <rhuijben_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_ra_serf/inherited_props.c Sat Jun 29 18:46:37 2013
>...
> +/* Conforms to svn_ra_serf__xml_closed_t */
> static svn_error_t *
> -end_element(svn_ra_serf__xml_parser_t *parser,
> - svn_ra_serf__dav_props_t name,
> - apr_pool_t *scratch_pool)
> +iprops_closed(svn_ra_serf__xml_estate_t *xes,
> + void *baton,
> + int leaving_state,
> + const svn_string_t *cdata,
> + apr_hash_t *attrs,
> + apr_pool_t *scratch_pool)
> {
>...
> + else if (leaving_state == IPROPS_PROPVAL)
> + {
>...
> svn_hash_sets(iprops_ctx->curr_iprop->prop_hash,
> apr_pstrdup(iprops_ctx->pool,
> iprops_ctx->curr_propname->data),
> - prop_val);
> - /* Clear current propname and propval in the event there are
> - multiple properties on the current path. */
> + val_str);

This assumes that the propname has been seen *before* the propval. The
server sends it in the proper order, but a comment noting this would
be good.

Or even a test that curr_propname->len > 0 (otherwise, SVN_ERR_XML_MALFORMED).

>...

Cheers,
-g
Received on 2013-06-29 23:01:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.