On 06/20/2013 06:30 PM, C. Michael Pilato wrote:
> Perhaps the better change is to make svn_repos__validate_prop() early-out
> (with success, of course) on a NULL value and adjust the rest of the code
> therein accordingly. I can see the benefit in flagging the *addition* (or
> modification) of a non-regular property (which is the first test that
> function performs), but there's need to block the ability to cleanup after
> such an errant change has already occurred. And we don't have any
> properties which are required to be present. So, again, I say there's no
> need to validate any type of property deletion.
Hi,
I'm not entirely sure what you want me to do. My current patch prevents
verification entirely during a delete. I don't see any merit in stepping
inside svn_repos__validate_prop. Also, did you mean to say "there's *no*
need to block the ability to cleanup after such an errant change has
already occurred" ?
Regards,
Arwin Arni
Received on 2013-06-21 08:36:21 CEST