[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Don't validate properties during deletion.

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Thu, 20 Jun 2013 09:00:22 -0400

Perhaps the better change is to make svn_repos__validate_prop() early-out
(with success, of course) on a NULL value and adjust the rest of the code
therein accordingly. I can see the benefit in flagging the *addition* (or
modification) of a non-regular property (which is the first test that
function performs), but there's need to block the ability to cleanup after
such an errant change has already occurred. And we don't have any
properties which are required to be present. So, again, I say there's no
need to validate any type of property deletion.

attached mail follows:


Received on 2013-06-20 15:00:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.