RE: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

> -----Original Message-----
> From: Ivan Zhakov [mailto:ivan_at_visualsvn.com]
> Sent: donderdag 20 juni 2013 15:41
> To: serf-dev_at_googlegroups.com; Bert Huijben
> Cc: dev_at_subversion.apache.org; Gert Kello
> Subject: Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in
> progress / Subversion regression
>
> On Thu, Jun 20, 2013 at 5:30 PM, Bert Huijben <bert_at_qqmail.nl> wrote:
> [...]
>
> > The patch to serf 1.2.1 attached to this mail is a (tiny bit cleaned up)
> > hack based on the old code in ra_serf, some code from an old serf branch
> and
> > the new in serf auth_kerb code, which re-enables the NTLM authentication
> > scheme in serf.
> >
> >
> I'm -1 for such patch:
> * It duplicates auth_kerb.c which intended to have the same auth code
> on different platforms with plugable platforms specific code
>
> * serf should not try use NTLM authentication if server supports Negotiate.

Do you have other code that works for these existing use cases?

I don't see that much duplication. This uses the existing plugin mechanism of serf, which still had defines for NTLM from before the NTLM stubs were removed on your Kerberos support branch.

That is the major reason why I didn't have to do anything but plugin an implementation.

If serf needs a better plugin mechanism we (or maybe you) should fix serf...
(It looks like the support is already negotiated... You can even disable schemes in the config)

Calling every user scenario except using VisualSVN server broken is not an option.

We can't just call Kerberos supported and drop NTLM support if many users still use this.

Using Subversion 1.7 with neon is 100% supported and we can't just break all 1.7 users to enable support for 1.8. That is 100% against our compatibility guarantees.

        Bert
Received on 2013-06-20 15:52:02 CEST