[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [serf-dev] [Patch] Adding NTLM Support to Serf - Work in progress / Subversion regression

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Thu, 20 Jun 2013 17:40:34 +0400

On Thu, Jun 20, 2013 at 5:30 PM, Bert Huijben <bert_at_qqmail.nl> wrote:
[...]

> The patch to serf 1.2.1 attached to this mail is a (tiny bit cleaned up)
> hack based on the old code in ra_serf, some code from an old serf branch and
> the new in serf auth_kerb code, which re-enables the NTLM authentication
> scheme in serf.
>
>
I'm -1 for such patch:
* It duplicates auth_kerb.c which intended to have the same auth code
on different platforms with plugable platforms specific code

* serf should not try use NTLM authentication if server supports Negotiate.

-- 
Ivan Zhakov
Received on 2013-06-20 15:41:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.