[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Strange failure of log_tests.py#7 -- missing commit in guarantee_repos_and_wc ?

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 6 Jun 2013 10:38:40 +0200

> -----Original Message-----
> From: Tobias Bading [mailto:tbading_at_web.de]
> Sent: donderdag 6 juni 2013 09:16
> To: Subversion Development
> Cc: Johan Corveleyn; Philip Martin; Bert Huijben
> Subject: Re: Strange failure of log_tests.py#7 -- missing commit in
> guarantee_repos_and_wc ?
>
> Hi *!
>
> On 06.06.2013 03:01, Johan Corveleyn wrote:
> > [...]
> >>> But even if the timestamp after the edit is precisely the same as
> >>> after the checkout, I don't understand how that can lead to 'commit'
> >>> not seeing that the file is modified: the edit changed the filesize,
> >>> and I thought both timestamp and filesize were considered to check for
> >>> modified files ...
> >> You are correct: both the timestamp and the filesize are checked (the
> >> code is in svn_wc__internal_file_modified_p). The timestamp "problem"
> >> only causes modifications to be missed if those modifications don't
> >> change the filesize. In this case the filesize should have changed.
>
> Grrrr. The author of diff-test 60 has a nice sense of humor it seems
> ;-). The merge in that test changes a lot of lines, but the size of file
> 3449_spurious stays the same. I didn't realize this until now. BTW, with
> the bad kernel, I've once seen special-test 21 (update_symlink) fail as
> well. Same reason I guess, a symbolic link is supposed to be changed
> from "link A/mu" to "link iota", so the file's size doesn't change and
> commit does nothing at all.

Can you provide a patch to these two tests that still make the tests check
their original target, but not trigger the timestamp problem?

I can probably fix this diff test, but fully testing the symlink scenarios
is not possible when running on Windows.

        Bert
Received on 2013-06-06 10:39:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.