[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Strange failure of log_tests.py#7 -- missing commit in guarantee_repos_and_wc ?

From: Tobias Bading <tbading_at_web.de>
Date: Thu, 06 Jun 2013 09:15:49 +0200

Hi *!

On 06.06.2013 03:01, Johan Corveleyn wrote:
> [...]
>>> But even if the timestamp after the edit is precisely the same as
>>> after the checkout, I don't understand how that can lead to 'commit'
>>> not seeing that the file is modified: the edit changed the filesize,
>>> and I thought both timestamp and filesize were considered to check for
>>> modified files ...
>> You are correct: both the timestamp and the filesize are checked (the
>> code is in svn_wc__internal_file_modified_p). The timestamp "problem"
>> only causes modifications to be missed if those modifications don't
>> change the filesize. In this case the filesize should have changed.

Grrrr. The author of diff-test 60 has a nice sense of humor it seems
;-). The merge in that test changes a lot of lines, but the size of file
3449_spurious stays the same. I didn't realize this until now. BTW, with
the bad kernel, I've once seen special-test 21 (update_symlink) fail as
well. Same reason I guess, a symbolic link is supposed to be changed
from "link A/mu" to "link iota", so the file's size doesn't change and
commit does nothing at all.

> OK, thanks. So certainly something fishy happened here. Some more
> thoughts below.
> On Wed, Jun 5, 2013 at 1:15 PM, Tobias Bading<tbading_at_web.de> wrote:
> ...
>> I had a similar timestamp related problem with diff-test 60. (See thread
>> http://mail-archives.apache.org/mod_mbox/subversion-users/201305.mbox/%3C519DDBE3.5040909%40web.de%3E
>> on the users list for details, if you're interested.)
> Thanks for jumping in here. Yes, I read that thread. But I don't think
> it's the same problem (see below).

I agree... until proven otherwise. ;-)
Received on 2013-06-06 09:16:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.