[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Windows Ruby changes

From: Paul Burba <ptburba_at_gmail.com>
Date: Tue, 28 May 2013 10:22:22 -0400

On Sun, May 26, 2013 at 2:23 AM, Daniel Shahaf <danielsh_at_elego.de> wrote:
> Paul,
>
> wrt the r1480344 group in STATUS: I think the 'rescue' block, here:
>
> ENV["PATH"].split(";").each do |path|
> +
> + # Change the cwd to path, but ignore non-existent paths.
> + begin
> + Dir.chdir(path)
> + rescue Errno::ENOENT
> + end
>
> should do the equivalent of 'continue;' in C. (Maybe it does so already?
> I expect it doesn't, but Ruby isn't my mother tongue.)

Nice catch Daniel. Indeed, what we want is the 'next' keyword. Fixed
in r1486931 and added to the backport group.

> With that 'continue' added, I'd approve the backport (by casting +0,
> which suffices in this case).
>
> Cheers,
>
> Daniel

--
Paul T. Burba
CollabNet, Inc. -- www.collab.net -- Enterprise Cloud Development
Skype: ptburba
Received on 2013-05-28 16:22:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.