[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1483292 - in /subversion/trunk/subversion: include/private/svn_string_private.h libsvn_subr/string.c libsvn_subr/types.c

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Thu, 16 May 2013 21:54:16 +0200

On Thu, May 16, 2013 at 7:52 PM, Mattias Engdegård <mattiase_at_bredband.net>wrote:

> 16 maj 2013 kl. 12.38 skrev Stefan Fuhrmann:
>
>
> Measurement was done on the server side (network and client
>> are not a bottleneck for log -g, yet). The server has to parse
>> through appox. 2GB of svn:mergeinfo.
>>
>
> In contrast to strtoul, this code lacks an overflow check. Presumably that
> was intended and is acceptable for where it is used, but perhaps it merits
> a comment?
>

Thanks for the feedback. Done in r1483535.

-- Stefan^2.

-- 
*Join one of our free daily demo sessions on* *Scaling Subversion for the
Enterprise <http://www.wandisco.com/training/webinars>*
*
*
Received on 2013-05-16 21:54:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.