Re: svn commit: r1483292 - in /subversion/trunk/subversion: include/private/svn_string_private.h libsvn_subr/string.c libsvn_subr/types.c

From: Mattias Engdegård <mattiase_at_bredband.net>
Date: Thu, 16 May 2013 19:52:50 +0200

16 maj 2013 kl. 12.38 skrev Stefan Fuhrmann:

> Measurement was done on the server side (network and client
> are not a bottleneck for log -g, yet). The server has to parse
> through appox. 2GB of svn:mergeinfo.

In contrast to strtoul, this code lacks an overflow check. Presumably
that was intended and is acceptable for where it is used, but perhaps
it merits a comment?
Received on 2013-05-16 19:53:25 CEST

This message: [ Message body ]
Next message: Stefan Fuhrmann: "Re: svn commit: r1483434 - /subversion/trunk/subversion/libsvn_subr/hash.c"
Previous message: Ben Reser: "Re: 1.8.0-rc2 up for testing/signing"
In reply to: Stefan Fuhrmann: "Re: svn commit: r1483292 - in /subversion/trunk/subversion: include/private/svn_string_private.h libsvn_subr/string.c libsvn_subr/types.c"
Next in thread: Stefan Fuhrmann: "Re: svn commit: r1483292 - in /subversion/trunk/subversion: include/private/svn_string_private.h libsvn_subr/string.c libsvn_subr/types.c"
Reply: Stefan Fuhrmann: "Re: svn commit: r1483292 - in /subversion/trunk/subversion: include/private/svn_string_private.h libsvn_subr/string.c libsvn_subr/types.c"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]