[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Pristine text missing - cleanup doesn't work

From: Johan Corveleyn <jcorvel_at_gmail.com>
Date: Mon, 22 Apr 2013 21:59:08 +0200

On Mon, Apr 22, 2013 at 4:34 PM, Julian Foad <julianfoad_at_btopenworld.com> wrote:
> I have filed this as issue #4357, "Pristine text missing - cleanup doesn't work", with a reference to this email thread.
>
> I thought of the following possible improvements, which I have noted in the doc string of pristine_cleanup_wcroot():
>
> * TODO: At least check that any zero refcount is really correct, before
> * using it.
> *
> * TODO: Ideas for possible extra clean-up operations:
> *
> * * Check and correct all the refcounts. Identify any rows missing
> * from the 'pristine' table. (Create a temporary index for speed
> * if necessary?)
> *
> * * Check the checksums. (Very expensive to check them all, so find
> * a way to not check them all.)
> *
> * * Check for pristine files missing from disk but referenced in the
> * 'pristine' table.
> *
> * * Repair any pristine files missing from disk and/or rows missing
> * from the 'pristine' table and/or bad checksums. Generally
> * requires contacting the server, so requires support at a higher
> * level than this function.
> *
> * * Identify any pristine text files on disk that are not referenced
> * in the DB, and delete them.
> *
> * TODO: Provide feedback about any errors found and any corrections made.
>
> Also, here is the "svn-fetch-pristine-by-sha1.sh" script that I mentioned in my initial email but forgot to attach there.
>

Great. Thanks for driving this, Julian.

Naively I'd say that any validation / repair that SmartSVN does (and
perhaps more) is interesting for inclusion in the core (or if not in
the core, a tool that's supported by the Subversion project is an
alternative).

--
Johan
Received on 2013-04-22 22:00:03 CEST

This is an archived mail posted to the Subversion Dev mailing list.