Re: Pristine text missing - cleanup doesn't work
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 22 Apr 2013 15:34:07 +0100 (BST)
I have filed this as issue #4357, "Pristine text missing - cleanup doesn't work", with a reference to this email thread.
I thought of the following possible improvements, which I have noted in the doc string of pristine_cleanup_wcroot():
* TODO: At least check that any zero refcount is really correct, before
* using it.
* TODO: Ideas for possible extra clean-up operations:
* * Check and correct all the refcounts. Identify any rows missing
* from the 'pristine' table. (Create a temporary index for speed
* if necessary?)
* * Check the checksums. (Very expensive to check them all, so find
* a way to not check them all.)
* * Check for pristine files missing from disk but referenced in the
* 'pristine' table.
* * Repair any pristine files missing from disk and/or rows missing
* from the 'pristine' table and/or bad checksums. Generally
* requires contacting the server, so requires support at a higher
* level than this function.
* * Identify any pristine text files on disk that are not referenced
* in the DB, and delete them.
* TODO: Provide feedback about any errors found and any corrections made.
Also, here is the "svn-fetch-pristine-by-sha1.sh" script that I mentioned in my initial email but forgot to attach there.
Johan Corveleyn wrote:
> On Thu, Apr 18, 2013 at 10:05 PM, Bert Huijben <firstname.lastname@example.org> wrote:
>> Johan Corveleyn reported that he heard multiple reports of this being caused
>> by earlier SvnKit versions. I have not got a single bugreport of this type
>> for AnkhSvn via our error reporting infrastructure.
>> I don’t see how anybody using SQLite can cause this as the updating of the
>> reference count is only handled by the triggers...
>> But SvnKit implemented their own clone, which used to have problems in this
> Indeed. But those errors have since been fixed (have not seen such
> problems anymore in the last half year or so).
> However ...
> On Thu, Apr 18, 2013 at 9:55 PM, Julian Foad <email@example.com> wrote:
>> I think we should do something to improve the situation. Fortunately it
>> seems to be relatively rare, as not many people have complained about it,
>> but there are over 5000 pages listed by Google with that error message.
> Big +1 from me.
> See my own prodding for improvement in this area.
> FWIW, I don't buy the argument that svn / sqlite can't break. Bugs (or
> rare cosmic ray disturbances or whatever) do happen. Having an 'svn
> repair' / 'svn validate' command or something (like SmartSVN's
> 'validate admin area') would definitely be nice.
This is an archived mail posted to the Subversion Dev mailing list.