[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1469520 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 19 Apr 2013 16:04:50 +0100

Daniel Shahaf <danielsh_at_elego.de> writes:

> What would a better fix be?

It's hard to say which is probably why these warnings have not been
addressed so far. The warning is a 'maybe':

../src/subversion/libsvn_fs_fs/tree.c:929:27: warning: 'directory' may be used uninitialized in this function [-Wmaybe-uninitialized]

so what will make it go away probably depends on various compiler
details. A better compiler optimiser might make the warning go away.

> The following is a first sketch, it should resolve the compiler warning
> but won't solve the actual semantic bug (if there is one) here.

I believe it's a false positive and there is no bug, other than the
warning, as 'directory' has to be non-NULL if 'here' is non-NULL.

Certified & Supported Apache Subversion Downloads:
Received on 2013-04-19 17:05:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.