[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1468439 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Wed, 17 Apr 2013 15:59:24 +0400

On Wed, Apr 17, 2013 at 3:21 PM, Bert Huijben <bert_at_qqmail.nl> wrote:
[...]
>
> Completely unrelated to this patch, but the usage of
> both info->props and info->dir->removed_props looks incorrect.
>
> Both props and removed_props are documented to be stored in
> the directory, but while removed_props is used that way the props
> hash sometimes is and sometimes isn't.
>
> Is the documentation partially outdated, or are we just 'lucky' that
> we don't test property removals that often in our testsuite?
>
I'm not familiar with pool usage in ra_serf update editor. Most likely
we are just 'lucky' because pool handling extremely complicated. So
you can just fix pool usage if you think current implementation has
problems.

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Received on 2013-04-17 14:00:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.