[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1468439 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 17 Apr 2013 13:21:44 +0200

> -----Original Message-----
> From: ivan_at_apache.org [mailto:ivan_at_apache.org]
> Sent: dinsdag 16 april 2013 16:36
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1468439 -
> /subversion/trunk/subversion/libsvn_ra_serf/update.c
>
> Author: ivan
> Date: Tue Apr 16 14:36:06 2013
> New Revision: 1468439
>
> URL: http://svn.apache.org/r1468439
> Log:
> Fix assertion on checkout from pre-1.8 server over ra_serf with
> http-bulk-updates=off.
>
> * subversion/libsvn_ra_serf/update.c
> (open_updated_file): Do not walk through file properties. They can be
> not fetched yet.
> (close_updated_file): Walk through file properties here.
>
> Modified:
> subversion/trunk/subversion/libsvn_ra_serf/update.c
>
> Modified: subversion/trunk/subversion/libsvn_ra_serf/update.c
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/
> update.c?rev=1468439&r1=1468438&r2=1468439&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/subversion/libsvn_ra_serf/update.c (original)
> +++ subversion/trunk/subversion/libsvn_ra_serf/update.c Tue Apr 16
> 14:36:06 2013
> @@ -1024,26 +1024,6 @@ open_updated_file(report_info_t *info,
> if (info->lock_token)
> check_lock(info);
>
> - /* Set all of the properties we received */
> - SVN_ERR(svn_ra_serf__walk_all_props(info->props,
> - info->base_name,
> - info->base_rev,
> - set_file_props, info,
> - scratch_pool));
> - SVN_ERR(svn_ra_serf__walk_all_props(info->dir->removed_props,
> - info->base_name,
> - info->base_rev,
> - remove_file_props, info,
> - scratch_pool));

Completely unrelated to this patch, but the usage of both info->props and info->dir->removed_props looks incorrect.

Both props and removed_props are documented to be stored in the directory, but while removed_props is used that way the props hash sometimes is and sometimes isn't.

Is the documentation partially outdated, or are we just 'lucky' that we don't test property removals that often in our testsuite?

        Bert
Received on 2013-04-17 13:22:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.