Re: [PATCH] Expand Perl bindings a bit

On Tue, Apr 16, 2013 at 11:35 AM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
> Can you provide a bit more explanation for the removal of
> revprop_table and changelists from MAY_BE_NULL

Can't pretend that I understand Swig very well either...
But what sense does it make to apply the mapping for some const char*
to a apr_hash_t* or apr_array_header_t*?

Anyway, these were causing totally weird code to be generated for
the Perl bindings - referencing undeclared (and uncalled for) variables
in wrapper functions.
Apply the other (non-Perl) patches and try to build the Perl bindings
and you'll see what I mean. Might be specific to the version of Swig,
though - I have 2.0.9.

On further investigation, "apr_array_header_t *changelists"
seems to be have been the culprit. It's also (mostly correct IMHO) mapped
in svn_client.i and svn_wc.i (though the latter gets it wrong wrt Perl -
maybe these mappings should be consolidateed to svn_types.swg).

Cheers, Roderich
Received on 2013-04-16 16:01:43 CEST