Re: [PATCH] Expand Perl bindings a bit

Roderich Schupp <roderich.schupp_at_gmail.com> writes:

> * subversion/bindings/swig/svn_client.i
> Drop three typemaps. The first two are obviously bogus and
> the third is redundant (it's also in svn_containers.swg).

> Index: subversion/bindings/swig/svn_client.i
> ===================================================================
> --- subversion/bindings/swig/svn_client.i (revision 1468311)
> +++ subversion/bindings/swig/svn_client.i (working copy)
> @@ -49,15 +49,9 @@
> %apply const char *MAY_BE_NULL {
> const char *native_eol,
> const char *comment,
> - const char *relative_to_dir,
> - apr_hash_t *revprop_table,
> - apr_array_header_t *changelists
> + const char *relative_to_dir
> };
>
> -%apply apr_hash_t *PROPHASH {
> - apr_hash_t *revprop_table
> -};
> -
> #ifdef SWIGRUBY
> %apply apr_hash_t *HASH_CSTRING_MAYBENULL {
> apr_hash_t *mimetypes_map

I don't understand SWIG very well so "obviously bogus" doesn't work for
me. Can you provide a bit more explanation for the removal of
revprop_table and changelists from MAY_BE_NULL. Is it because the NULL
is handled by the other mappings for those types?

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download