[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Missing newline in propset error message

From: Ben Reser <ben_at_reser.org>
Date: Mon, 15 Apr 2013 10:04:36 -0700

On Mon, Apr 15, 2013 at 9:11 AM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
> That's just repeating what Mattias said. What I want to clarify is why
> we want to use a double printf rather than having a new string.

The existing translation key doesn't have a newline on it. Most of
the uses it is inappropriate to just add a new line to, since most of
them are going into svn_error_t. The alternative to what he's doing
is to add a second translation key that has a newline, which creates
extra busy work for translators.

Another alternative would be to do another svn_cmdline_print of just
"\n". Perhaps that's less messy, but I don't have particularly strong
opinions on this.
Received on 2013-04-15 19:05:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.