[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Missing newline in propset error message

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 15 Apr 2013 17:11:36 +0100

Ben Reser <ben_at_reser.org> writes:

> On Mon, Apr 15, 2013 at 6:38 AM, Philip Martin
> <philip.martin_at_wandisco.com> wrote:
>> Mattias EngdegÄrd <mattiase_at_bredband.net> writes:
>>
>>> Here is a patch. (I didn't add a newline to the string directly since
>>> it occurs in many places.)
>>
>> The explaination should go in the code not the email otherwise somebody
>> else may change the code. I don't understand the explaination, is this
>> to make translation easier?
>
> Search our codebase for 'is not under version control', it gets used
> as the message for errors a lot.

That's just repeating what Mattias said. What I want to clarify is why
we want to use a double printf rather than having a new string.

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2013-04-15 18:12:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.