[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Printing error stacks.

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 12 Apr 2013 15:16:23 -0400

On 04/12/2013 02:53 PM, Daniel Shahaf wrote:
> Another idea: avoid printing the (apr_err=) part if it's the same code as the
> line above it (which should be the common case):
>
> subversion/svn/checkout-cmd.c:168 (apr_err=SVN_ERR_RA_LOCAL_REPOS_OPEN_FAILED)
> subversion/libsvn_client/checkout.c:197 (apr_err=^)
> subversion/libsvn_client/checkout.c:100 (apr_err=^)
> subversion/libsvn_client/ra.c:541 (apr_err=^)
> subversion/libsvn_client/ra.c:393 (apr_err=^)
> subversion/libsvn_ra/ra_loader.c:482 (apr_err=^)
> svn: E180001: Unable to connect to a repository at URL 'file:///home/cmpilato/tests/arch'
> subversion/libsvn_ra_local/ra_plugin.c:578 (apr_err=^)
> svn: E180001: Unable to open an ra_local session to URL
> subversion/libsvn_ra_local/split_url.c:46 (apr_err=SVN_ERR_SOMETHING_ELSE)
> svn: E180003: Unable to open repository 'file:///home/cmpilato/tests/arch'

I like the brevity. One concern that I have with this (and with the current
output, for that matter) is that there is really nothing that tells me that
E180003 means SVN_ERR_RA_LOCAL_REPOS_OPEN_FAILED. I've got a line which
lists the symbolic name, a bunch of lines with effectively say "ditto", and
then a line of actual "meat" that refers only to a number and *not* the name.

>> svn: E180003: Unable to connect to a repository at URL 'file:///home/cmpilato/tests/arch'
>> svn: E180012: Unable to open an ra_local session to URL
>> svn: E180001: Unable to open repository 'file:///home/cmpilato/tests/arch'
>> (E1800001 = SVN_ERR_RA_LOCAL_REPOS_OPEN_FAILED)
>> (E1800003 = SVN_ERR_SOMETHING_ELSE)
>> (E1800012 = SVN_ERR_YET_ANOTHER_FAILURE)
>>
>> Thoughts?
>
> That's an interesting idea. I don't have a strong opinion on it at the moment.

Fair 'nuff.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2013-04-12 21:17:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.