Re: svn commit: r1464769 - in /subversion/trunk/subversion/libsvn_client: revert.c switch.c update.c
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Fri, 5 Apr 2013 18:29:36 +0100 (BST)
Philip Martin wrote:
> Julian Foad <julianfoad_at_btopenworld.com> writes:
NTP or similar mechanisms, I assume.
> I would suspect that some (lots?) don't do anything and have large skew.
Fair point, so it won't significantly help people who get a 1ms sleep. My "near past" argument above works for people who get a one-second sleep, such as myself, assuming synchronization to within a fraction of a second.
> I still think it's odd to sleep when use-commit-times=yes but not enough
I agree it's odd, but without a substantial re-work to note the actual timestamps that we're recording (in libsvn_wc), the best we can do is choose either to sleep or not to sleep. To summarize how we're leaving it now, we're calling the sleep function regardless of use-commit-times setting, for all commands that sleep. Compared with how it was before my two commits, the only change in this respect is removing the exception that previously 'revert' was skipping the sleep if using commit times, while the other operations were sleeping regardless.
This is an archived mail posted to the Subversion Dev mailing list.