[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1463721 - in /subversion/trunk/subversion/libsvn_client: checkout.c client.h commit.c copy.c export.c externals.c revert.c switch.c update.c

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 3 Apr 2013 01:55:02 +0100 (BST)

Philip Martin wrote:

>> + cleanup:
>>     /* Sleep to ensure timestamp integrity. */
>> -  svn_io_sleep_for_timestamps(base_abspath, pool);
>> +  if (commit_in_progress)
>> +    svn_io_sleep_for_timestamps(base_abspath, pool);
>
> This bit doesn't look right.  commit_in_progress is set back to FALSE
> before post-commit processing so as far as I can see a successful commit
> no longer sleeps.  This ould explain the buildbot failures
> http://ci.apache.org/builders/svn-x64-centos-gcc/builds/9039

Thanks for catching this.  I hadn't noticed the "commit_in_progress = FALSE".  Will fix.

r1463803.  Hope that does it.

- Julian
Received on 2013-04-03 02:55:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.