[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1463721 - in /subversion/trunk/subversion/libsvn_client: checkout.c client.h commit.c copy.c export.c externals.c revert.c switch.c update.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 02 Apr 2013 23:57:31 +0100

julianfoad_at_apache.org writes:

> Author: julianfoad
> Date: Tue Apr 2 19:53:43 2013
> New Revision: 1463721
> after releasing it in other places. We should pick one and be consistent.

> --- subversion/trunk/subversion/libsvn_client/commit.c (original)
> +++ subversion/trunk/subversion/libsvn_client/commit.c Tue Apr 2 19:53:43 2013
> @@ -985,10 +985,11 @@ svn_client_commit6(const apr_array_heade
> iterpool);
> }
>
> + cleanup:
> /* Sleep to ensure timestamp integrity. */
> - svn_io_sleep_for_timestamps(base_abspath, pool);
> + if (commit_in_progress)
> + svn_io_sleep_for_timestamps(base_abspath, pool);

This bit doesn't look right. commit_in_progress is set back to FALSE
before post-commit processing so as far as I can see a successful commit
no longer sleeps. This ould explain the buildbot failures
http://ci.apache.org/builders/svn-x64-centos-gcc/builds/9039

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2013-04-03 00:58:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.