[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] run_test.py appearance changes

From: Gabriela Gibson <gabriela.gibson_at_gmail.com>
Date: Mon, 01 Apr 2013 22:36:57 +0100

On 01/04/13 01:31, Daniel Shahaf wrote:
I reworked hunk 2 because I found a bug.

The actual problem I saw was caused because the script didn't handle the
case where the terminal dimension returns as (0,0). I've fixed
this in the new patch, and cleaned up inefficient code.

> I did note, though, that you missed adding the SVN_DEPRECATED
> marker to the being-deprecated function.

Thanks :) I'll fix that once I have some feedback on the rest.

[[[

Disable ANSI color for dumb terminals, fix logic bug where
dimensions of (0,0) was treated as a positive result,
re-factored _run_tests to remove repeated calculation of
line_length.

* build/run_tests.py
   (_get_term_width): Add test condition.
   (TestHarness): Add new variable.
   (_run_test): Add new parameter, remove function call.

]]]

Received on 2013-04-01 23:37:02 CEST

This is an archived mail posted to the Subversion Dev mailing list.