I've just completed my review of the new-in-1.8 public APIs, minus the bits
that Philip reviewed (thanks!) and the new merge-related stuff which, if I
understand from recent threads correctly, is still subject to some churn.
The results of my review revealed overwhelmingly positive results which, in
my approximation, are non-contentious. I had (for some definition of "had")
to touch up quite a few docstring in the process, but by and large those
were stylistic nits with the occasionally overlooked item.
The current state of the review work may be found here:
Please note especially the section labeled "Reviewed But Need Further
Attention". In it, I call out some of the stuff about which I couldn't come
to clear and obvious conclusion/solution/etc. Please take a moment to
review that section, and to follow up with an appropriate action on any API
items which may have been the result of your own work or involve an area of
the codebase with which you are suitably familiar.
Finally, as a special request, I'm going to ask that Paul and Julian work
together on that final bit of merge-function-related review from
svn_client.h -- their two sets of combined can ensure that these APIs are OK
for release much more so than my own somewhat out-of-touch opinions here.
(Fortunately, Mark and others have already chimed in on the Java
manifestations of some of these APIs, which adds further review value!)
Thanks, and may 1.8 branch ASAP!
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet <> www.collab.net <> Enterprise Cloud Development
Received on 2013-03-29 21:18:24 CET