[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1461590 - in /subversion/trunk/subversion: libsvn_diff/diff_file.c tests/libsvn_diff/diff-diff3-test.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 28 Mar 2013 13:17:43 +0100

> -----Original Message-----
> From: MARTIN PHILIP [mailto:codematters_at_ntlworld.com] On Behalf Of
> Philip Martin
> Sent: donderdag 28 maart 2013 12:18
> To: Johan Corveleyn
> Cc: philip_at_apache.org; dev_at_subversion.apache.org
> Subject: Re: svn commit: r1461590 - in /subversion/trunk/subversion:
> libsvn_diff/diff_file.c tests/libsvn_diff/diff-diff3-test.c
>
> Johan Corveleyn <jcorvel_at_gmail.com> writes:
>
> > I can spend more time on this in a week or two, but if you want to dig
> > into it sooner, I think a better fix would be something like this
> > (untested / uncompiled):
>
> I extended the test and committed your patch in r1462041.

For the mailing list history:
13:02 <@Bert> philipm: Did you see the problem described by jcorvel in his
mail? Or is the fix+test to be on the safe
              side?
13:02 < philipm> What problem exactly?
13:03 <@Bert> philipm: r1462041
13:04 < philipm> I see, what you are asking is did the previous fix still
allow invalid reads to occur?
13:04 <@Bert> *nod* Exactly
13:04 < philipm> Yes, the extended test causes invalid read with the
previous fix.
13:05 < philipm> The invalid read doesn't occur with the new fix.

        Bert
Received on 2013-03-28 13:18:22 CET

This is an archived mail posted to the Subversion Dev mailing list.