[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1462054 - in /subversion/branches/verify-at-commit/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Thu, 28 Mar 2013 14:14:43 +0200

Philip Martin wrote on Thu, Mar 28, 2013 at 12:09:30 +0000:
> Stefan Sperling <stsp_at_elego.de> writes:
>
> > If we decide that verifying transactions before commit is a good
> > thing, I'd much rather see a new 'svnlook verify' command that can
> > be run from the pre-commit hook, instead of this implementation.
>
> A separate process could be a performance hit since it would not share
> the FSFS cache used by the commit process. On the other hand a separate
> process might be an advantage if there is a caching bug.

That's good. There is already a comment in svn_fs_fs__verify_root()
asking how to disable/bypass caching; "use a child process" is a good
start...

Do we have any per-machine caches? Or only per-process and memcached?
Received on 2013-03-28 13:15:29 CET

This is an archived mail posted to the Subversion Dev mailing list.